From 9e8ee5bb4a1bc92f932f3195a3d77f734703a3fd Mon Sep 17 00:00:00 2001 From: Thilo Schwarz Date: Fri, 9 Jan 2026 15:25:33 +0100 Subject: [PATCH] Refactor tests: Replace `assertTrue(size >= 1)` with `assertFalse(isEmpty)` for clarity and correctness. --- src/test/java/codes/thischwa/cf/CfClientTest.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/test/java/codes/thischwa/cf/CfClientTest.java b/src/test/java/codes/thischwa/cf/CfClientTest.java index 81498ec..6e426f3 100644 --- a/src/test/java/codes/thischwa/cf/CfClientTest.java +++ b/src/test/java/codes/thischwa/cf/CfClientTest.java @@ -1,6 +1,7 @@ package codes.thischwa.cf; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -167,13 +168,13 @@ public class CfClientTest { // test recordList with types without SLD List aList = client.recordList(z, RecordType.A); - assertTrue(aList.size() >= 1); + assertFalse(aList.isEmpty()); assertTrue(aList.stream().anyMatch(re -> re.getId().equals(createdRe1.getId()))); assertTrue(aList.stream().noneMatch(re -> re.getId().equals(createdRe2.getId()))); // test fluent api list List fluentList = client.zone(ZONE_STR).list(RecordType.A); - assertTrue(fluentList.size() >= 1); + assertFalse(fluentList.isEmpty()); assertTrue(fluentList.stream().anyMatch(re -> re.getId().equals(createdRe1.getId()))); // update AAAA record