thischwa/CloudflareDNS-java
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 1 Activity

Refactor tests: Replace assertTrue(size >= 1) with assertFalse(isEmpty) for clarity and correctness.

Browse Source
This commit is contained in:
Thilo Schwarz
2026-01-09 15:25:33 +01:00
parent 34010a4e77
commit 9e8ee5bb4a
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/java/codes/thischwa/cf/CfClientTest.java
+3 -2
View File
@@ -1,6 +1,7 @@
package codes.thischwa.cf; package codes.thischwa.cf;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -167,13 +168,13 @@ public class CfClientTest {
// test recordList with types without SLD // test recordList with types without SLD
List<RecordEntity> aList = client.recordList(z, RecordType.A); List<RecordEntity> aList = client.recordList(z, RecordType.A);
assertTrue(aList.size() >= 1); assertFalse(aList.isEmpty());
assertTrue(aList.stream().anyMatch(re -> re.getId().equals(createdRe1.getId()))); assertTrue(aList.stream().anyMatch(re -> re.getId().equals(createdRe1.getId())));
assertTrue(aList.stream().noneMatch(re -> re.getId().equals(createdRe2.getId()))); assertTrue(aList.stream().noneMatch(re -> re.getId().equals(createdRe2.getId())));
// test fluent api list // test fluent api list
List<RecordEntity> fluentList = client.zone(ZONE_STR).list(RecordType.A); List<RecordEntity> fluentList = client.zone(ZONE_STR).list(RecordType.A);
assertTrue(fluentList.size() >= 1); assertFalse(fluentList.isEmpty());
assertTrue(fluentList.stream().anyMatch(re -> re.getId().equals(createdRe1.getId()))); assertTrue(fluentList.stream().anyMatch(re -> re.getId().equals(createdRe1.getId())));
// update AAAA record // update AAAA record